Re: [PATCH] i2c: i2c-omap: Fix BUFSTAT_REG reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 14 November 2008, ext-eero.nurkkala@xxxxxxxxx wrote:
> The amount of bytes to receive is read from wrong
> place. It is the 6 bits starting from the bit 8 from
> BUFSTAT_REG that indicate this amount. Not the 8 LSB:s.
> Only 6 LSB:s are used for the TX buffer. Also, with
> omap 3430, only the 6 LSB:s are relevant for XDR.

So to summarize:  2430 and 3430 define this register
differently?  Lacking 2430 docs, I can't verify that.

Agreed that 3430 has two 6-bit fields, RXSTAT at 8..13
and TXSTAT at 0..5, so this code is wrong for 3430.

But if the issue is that the 2430 version of the FIFO
support works differently, please say so in the patch
commend and code...

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux