> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Koen Kooi > Sent: Friday, November 14, 2008 5:09 PM > To: Hiremath, Vaibhav > Cc: linux-fbdev-devel@xxxxxxxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [REVIEW PATCH] Added OMAP3EVM support on Tomis FBDEV/DSS Patches > > > Op 14 nov 2008, om 07:32 heeft hvaibhav@xxxxxx het volgende geschreven: > > > > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach- > > omap2/board-omap3evm.c > > > > + if (system_rev > OMAP3430_REV_ES1_0) { > > + twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, > > + ENABLE_VPLL2_DEDICATED, TWL4030_VPLL2_DEDICATED); > > + twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, > > + ENABLE_VPLL2_DEV_GRP, TWL4030_VPLL2_DEV_GRP); > > + } > > + gpio_direction_output(LCD_PANEL_ENABLE_GPIO, 0); > > + lcd_enabled = 1; > > + return 0; > > +} > > + > > +static void panel_disable_lcd(struct omap_display *display) > > +{ > > + if (system_rev > OMAP3430_REV_ES1_0) { > > + twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, 0x0, > > + TWL4030_VPLL2_DEDICATED); > > + twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, 0x0, > > + TWL4030_VPLL2_DEV_GRP); > > + } > > + omap_set_gpio_dataout(LCD_PANEL_ENABLE_GPIO, 1); > > + lcd_enabled = 0; > > +} > > system_rev() is now omap_rev(), you'll get a really green picture > without that change :) > > I can confirm that the panel-sdp3430 works on the evm. [Shah, Hardik] Hi panel-omap3evm.c is working fine. We tested that. And we were getting the green picture. Thanks for pointing that out. We will change this also in our next patch. > > regards, > > Koen -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
