Thanks, Vaibhav Hiremath > -----Original Message----- > From: Koen Kooi [mailto:k.kooi@xxxxxxxxxxxxxxxxxx] > Sent: Friday, November 14, 2008 2:31 PM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx List > Subject: Re: [REVIEW PATCH] Added OMAP3EVM support on Tomis > FBDEV/DSS Patches > > > Op 14 nov 2008, om 07:32 heeft hvaibhav@xxxxxx het volgende > geschreven: > > > > > +++ b/drivers/video/omap2/panel-dvi.c > > @@ -52,54 +52,20 @@ static struct omap_panel dvi_panel = { > > .disable = dvi_panel_disable, > > /*.set_mode = dvi_set_mode, */ > > > > -#if defined(CONFIG_PANEL_DVI_LOWRES) > > .timings = { > > - /* 800 x 600 @ 60 Hz Reduced blanking VESA CVT 0.48M3-R > */ > > - .pixel_clock = 35500, > > - .hfp = 48, > > - .hsw = 32, > > - .hbp = 80, > > - .vfp = 3, > > - .vsw = 4, > > - .vbp = 11, > > + /* 480P */ > > + .pixel_clock = 30000, > > + .hfp = 24, > > + .hsw = 40, > > + .hbp = 96, > > + .vfp = 10, > > + .vsw = 3, > > + .vbp = 32, > > }, > > > > - .x_res = 800, > > - .y_res = 600, > > + .x_res = 480, > > + .y_res = 720, > > .bpp = 24, > > -#elif defined(CONFIG_PANEL_DVI_HIGHRES) > > - .timings = { > > - /* 1024 x 768 @ 60 Hz Reduced blanking */ > > - .pixel_clock = 56000, > > - .hfp = 48, > > - .hsw = 32, > > - .hbp = 80, > > - .vfp = 3, > > - .vsw = 4, > > - .vbp = 15, > > - }, > > - > > - .x_res = 1024, > > - .y_res = 768, > > - .bpp = 24, > > -#elif defined(CONFIG_PANEL_DVI_VERYHIGHRES) > > - .timings = { > > - /* 1280 x 1024 @ 57 Hz Reduced blanking */ > > - .pixel_clock = 86500, > > - .hfp = 48, > > - .hsw = 32, > > - .hbp = 80, > > - .vfp = 3, > > - .vsw = 4, > > - .vbp = 15, > > - }, > > - > > - .x_res = 1280, > > - .y_res = 1024, > > - .bpp = 16, > > -#else > > -#error Undefined default mode > > -#endif > > Can't the 480p mode the _added_ to the dvi file instead of removing > all non-480p modes? > [Hiremath, Vaibhav] Since LOWERS/HIGHERS/VERYHIGHERS doesn't convey meaningful information, I thought of changing this. So started with 480P, after addition of more modes say 720P, etc... we will have config option depending on the modes. > regards, > > Koen -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
