Re: [PATCH] omap: get rid of OMAP_TAG_USB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 11, 2008 at 10:20:33PM -0800, David Brownell wrote:
> On Friday 24 October 2008, Felipe Balbi wrote:
> > > --- a/arch/arm/plat-omap/include/mach/usb.h
> > > +++ b/arch/arm/plat-omap/include/mach/usb.h
> > > @@ -29,6 +29,7 @@
> > >  
> > >  void __init usb_musb_init(void);
> > >  void __init usb_ehci_init(void);
> > > +void omap_usb_init(struct omap_usb_config *pdata);
> > >  
> > >  #endif
> > >  
> 
> That "#endif" is for the !OMAP1 branch ... so this patch
> couldn't built on on any OMAP1 platform at all.  And for
> OSK, you put the USB init in with the Mistral-specific
> init ... but most OSKs don't connect to a Mistral.
> 
> The following patch gets it to build OK for my OSK, but
> then omap_udc hit some new locking bug.  Sigh.

Thanks for testing, I'll review the patch again ;-)

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux