Re: [OMAP and mainline][RFC 2.6.28-rc2-omap 3/3] USB: OHCI-OMAP: Switch to gpio_request/free calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 11 November 2008, Jarkko Nikula wrote:
> 
> > Sure, you send me a drivers/gpio/gpiolib.c update and I'll
> > sign off on it.  20 chars would be better than 12, but
> > maybe more are needed.
> > 
> I'll try do as soon as possible. Some "work" and other side stuff has
> unfortunately delayed this gpio & patchset update recently.
> 
> Do you see are there any issue to change label into last column like
> in /proc/interrupts so that width doesn't have to be fixed?

Only that the amount of data to the right of that label
is variable size too.  I was following a convention that
the standard debug dump code (gpiolib) and the gpio_chip
specific stuff all looked pretty much the same except for
the extras (pullups, pulldowns, drive strength, debounce,
and so on) on the right.

I'd keep it simple and just allow for fatter labels.
Less work all around.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux