* Felipe Balbi <me@xxxxxxxxxxxxxxx> [081111 15:50]:
> On Tue, Nov 11, 2008 at 03:47:13PM -0800, Tony Lindgren wrote:
> > * Felipe Balbi <me@xxxxxxxxxxxxxxx> [081111 15:22]:
> > > On Wed, Nov 12, 2008 at 12:56:19AM +0200, Felipe Balbi wrote:
> > > > From: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> > > >
> > > > Get rid of omap_{read,write}[bsl] defines.
> > > > Virtual and physical addresses usage was fixed by Russel King and
> > > > there's no need anymore for keeping a define to a standard kernel
> > > > function. Get rid of those to keep the namespace cleaner.
> > > >
> > > > Build tested with all omap defconfigs.
> > > > Depends on my previous "make clk fwk build again on omap1" patch.
> > >
> > > for convinience, these patches plus the clock fix for omap1 and the mmc
> > > fix are available at [1]
> >
> > Felipe, have you tested any of these? To me looks like you're missing
> > the associated ioremap before you can use __raw_read/write instead of
> > omap_read/write.
>
> You're right, I should at least use __raw_read/write(IO_ADDRESS(...));
Adding the IO_ADDRESS there is the wrong fix though, let's rather keep
what we have.
> I'll fix it by tomorrow and test on omap3.
How about we convert them one at a time to use ioremap +
__raw_read/write instead?
Pretty much the only place where ioremap cannot be used is in sram.c,
and that has a comment about it. And clock fwk stuff we should not
mess with right now.
Cheers,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
