----- Original Message ----- From: <ext-eero.nurkkala@xxxxxxxxx>
To: <linux-omap@xxxxxxxxxxxxxxx> Cc: "Eero Nurkkala" <ext-eero.nurkkala@xxxxxxxxx> Sent: Tuesday, November 11, 2008 12:21 PM Subject: [PATCH] i2c: i2c-omap: Fix BUFSTAT_REG reading
From: Eero Nurkkala <ext-eero.nurkkala@xxxxxxxxx> The amount of bytes to receive is read from wrong place. It is the 6 bits starting from the bit 8 from BUFSTAT_REG that indicate this amount. Not the 8 LSB:s. 6 LSB:s are used for the TX buffer. Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@xxxxxxxxx> --- drivers/i2c/busses/i2c-omap.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index a999606..f15668d 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -621,8 +621,9 @@ omap_i2c_isr(int this_irq, void *dev_id) if (stat & OMAP_I2C_STAT_RRDY) num_bytes = dev->fifo_size; else - num_bytes = omap_i2c_read_reg(dev, - OMAP_I2C_BUFSTAT_REG); + num_bytes = (omap_i2c_read_reg(dev, + OMAP_I2C_BUFSTAT_REG) + >> 8) & 0x3F; }
I believe "And"ing by 0x3F will apply to transmit also.
while (num_bytes) { num_bytes--; -- 1.6.0 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html