Hi,
On Fri, Nov 07, 2008 at 09:41:26PM +0800, Stanley.Miao wrote:
> Add Ethernet device support in board-ldp.c to make ldp can boot and mount nfs
> successfully.
Normally, defconfig changes come in a separate patch. Please split
defconfig out of this patch and fix these:
WARNING: suspect code indent for conditional statements
#292: FILE: arch/arm/mach-omap2/board-ldp.c:213:
+ if (gpmc_cs_request(eth_cs, SZ_16M, &cs_mem_base) < 0) {
ERROR: code indent should use tabs where possible
#293: FILE: arch/arm/mach-omap2/board-ldp.c:214:
+ printk(KERN_ERR "Failed to request GPMC mem for smc911x\n");$
ERROR: code indent should use tabs where possible
#294: FILE: arch/arm/mach-omap2/board-ldp.c:215:
+ return;$
WARNING: suspect code indent for conditional statements
#305: FILE: arch/arm/mach-omap2/board-ldp.c:226:
+ if (omap_request_gpio(eth_gpio) < 0) {
ERROR: code indent should use tabs where possible
#306: FILE: arch/arm/mach-omap2/board-ldp.c:227:
+ printk(KERN_ERR "Failed to request GPIO%d for smc911x IRQ\n",$
ERROR: code indent should use tabs where possible
#307: FILE: arch/arm/mach-omap2/board-ldp.c:228:
+ eth_gpio);$
ERROR: code indent should use tabs where possible
#308: FILE: arch/arm/mach-omap2/board-ldp.c:229:
+ return;$
ERROR: code indent should use tabs where possible
#319: FILE: arch/arm/mach-omap2/board-ldp.c:240:
+ ldp_init_smc911x();$
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
