On Wed, 22 Oct 2008 23:50:54 -0700 "ext David Brownell" <david-b@xxxxxxxxxxx> wrote: > Following this are four patches matching $SUBJECT: > > - remove omap_set_gpio_dataout() and omap_get_gpio_datain() > ... same call syntax, different name, minor code shrink > - use gpio_direction_input() > ... minor call syntax change, otherwise not interesting > - use gpio_direction_output(), remove omap_set_gpio_direction() > ... different call syntax and initialization model > - use gpio_to_irq() > ... at least, outside of static initializers > > The third patch might conceivably make trouble; see the patch > comments. Ditto the fourth, but IMO that's less likely. > > I did test builds for OMAP1, OMAP2420, OMAP2430, and OMAP3430, > and tried to make sure all the files affected by this patch > got rebuilt. The build breakage was mostly related to McBSP > and iomem pointers; nothing affected by these patches. > > Two remaining OMAP GPIO calls can be removed a bit later: > > int omap_request_gpio(int gpio); > void omap_free_gpio(int gpio); > > Once that's done, I think it'll be time to move the GPIO > code into mach-omap1/mach-omap2 ... the OMAP2/OMAP3 stuff > in particular should become a LOT simpler. > Hi David Did you know what? I was doing something like similar conversion patches just few days ago but didn't find yet time to finalize them and fix arch/arm/plat-omap/gpio.c for omap_[request | free]_gpio :-) My set was basically doing all gpiolib conversions in one patch and the set was grouped so that one patch for all OMAP1 boards (all of them are in mainline), separate patches for couple OMAP2 boards and some random patches for different drivers. I can add omap_request_gpio/omap_free_gpio conversion patch on top of yours but probably that will go somewhere next week. Useful conversion due label argument in gpio_request :-) Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
