Re: [PATCH 2/5] OMAP242x omapdev: add OMAP242x omapdev records

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 18 October 2008, Paul Walmsley wrote:
> --- a/arch/arm/mach-omap2/omapdev-common.h
> +++ b/arch/arm/mach-omap2/omapdev-common.h
> @@ -21,6 +21,87 @@
>  #include "omapdev3xxx.h"
>  
>  static struct omapdev *omapdevs[] = {
> +
> +#ifdef CONFIG_ARCH_OMAP2420
> +       &mpu_242x_omapdev,
> +       &iva_242x_omapdev,
> +       &gfx_242x_omapdev,
>	...

Urgh, this is unpleasant style:  declaration of a large
static data structure in a header file.

Cleaner:  just have some omap2420-specific C file declare
the struct, and hand it off to whatever code uses it.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux