Re: [PATCH 0/3] Move twl4030 scripts to platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 07 October 2008, Peter 'p2' De Schrijver wrote:
> This patch set move the twl4030 scripts to platform data
> and integrates the code to download the scripts with the
> new twl4030 codebase.  
> 
> Peter 'p2' De Schrijver (3):
>   Add twl4030 scripts to 3430sdp platform data
>   Adapt twl4030 power code to new twl4030 code
>   Add twl4030 power platform device

Good. Those scripts were absolutely not in the
right kind of location before!

Your patch comments are all rather uniformly
empty though, worth fixing ... 

... and patch #1 (add scripts) breaks compiles,
it should include the header update from #2.

And I'll suggest a patch #4 to move this from
the drivers/i2c/chips directory to someplace
more appropriate.  Not that I have a sugggestion
on where; but drivers/i2c is clearly wrong!

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux