Hello Russell, On Tue, 7 Oct 2008, Russell King - ARM Linux wrote: > One thing I've noticed, however, is that there seem to be clocks which > result in omap2_clk_wait_ready() being called, which checks the "other" > F or I clock register, but there's no corresponding clock defined in > the source for that bit. Eg, iva1_ifck in clock24xx.h. What does it > mean? Bug. (Harmless, but a bug nonetheless.) It's fixed in the current linux-omap head. Those patches are scheduled for a future merge window, but would be pleased to send those sooner if you like. The omap2_clk_wait_ready() function is one of the worst legacies of the old code. Code aside, one might reasonably assume that it waits for a clock to become ready. But it actually waits for a device, not a clock, to indicate that it is no longer idle. The practical impact of this is that a device will trigger interconnect errors if its registers are accessed while it's still idle. Only a subset of devices can indicate readiness. The plan in the medium term is to move this function to a device layer, and call it something like "omap2_device_wait_ready()". Comments and ideas very welcome, - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
