On Monday 06 October 2008, Ajay Kumar Gupta wrote: > + if (is_in) > + musb->periodic[2 * ep->epnum - 2] = NULL; > + else > + musb->periodic[2 * ep->epnum - 1] = NULL; Can we use musb->in[], musb->out[] or somesuch? Magic index math is kind of error prone ... > - case USB_ENDPOINT_XFER_CONTROL: > - case USB_ENDPOINT_XFER_BULK: > - /* fifo policy for these lists, except that NAKing > - * should rotate a qh to the end (for fairness). > - */ You just moved that bit earlier. Please just leave it in the same place, so it's easier to tell what changed... -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html