Re: [PATCH 02/10] ARM: OMAP: Fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 6 Oct 2008, Russell King - ARM Linux wrote:

> On Mon, Oct 06, 2008 at 08:52:46AM -0600, Paul Walmsley wrote:
> > OK.  Tony's tree contains some patches which thoroughly clean this 
> > function up, but they are large.  Would you like me to send those along 
> > with this patch set, or would you prefer that I just drop this part of the 
> > patch and repost?
> 
> Probably the most productive solution is to drop that part and repost.

Will do.

> However, my thoughts from looking over the existing clock code is that,
> at some point, I'd like to rewrite the entire OMAP clk code to get rid
> of stuff like this.  Realistically, I'm scared to do so - the current
> implementation is very complex that getting a proper overview is rather
> difficult...

Perhaps the current code in Tony's tree at:

http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=blob;f=arch/arm/mach-omap2/clock.c;h=c3af24e8e3e557029f3cc07a7c8384d3a4befdd2;hb=HEAD#l298

is more reasonable?

(human readable reference: line 298 of arch/arm/mach-omap2/clock.c)


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux