On Mon, Oct 06, 2008 at 03:54:57PM +0300, ext Riku Voipio wrote: > On Mon, Oct 06, 2008 at 02:51:03PM +0300, Felipe Balbi wrote: > > On Mon, Oct 06, 2008 at 02:17:23PM +0300, Tony Lindgren wrote: > > > * Riku Voipio <riku.voipio@xxxxxx> [081006 14:09]: > > > > On Mon, Oct 06, 2008 at 12:11:31PM +0300, Felipe Balbi wrote: > > > > > This driver should be sitting together with the other > > > > > led drivers. > > > > > > > > But this driver actually doesn't implement the led sysfs interface. > > > > If the driver is changed to implement the led framework interface, > > > > we break the existing n810 userland and expose only limited subset > > > > of lp5521 features for userland.. > > > > > > Maybe this feature should be a distro specific hack on top of > > > the mainline tree? > > > > the problem is that led api (afaict) doesn't really have abstraction for > > rgb leds like the one we use. It can only handle blinky leds and on/off > > transitions and we need more functionality. > > RGB can somewhat be handled, by creating three led devices: > > n810:red:foo > n810:gree:foo > n810:blue:foo If that's the case I'd expect the driver author to do it since I have no time left for that. A few fixes here and there to the driver is fine and preparing the driver for mainline integration is also fine since it's a simple cp iteration. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
