Mauro Carvalho Chehab wrote:
On Fri, 3 Oct 2008 20:10:36 +0530
"Shah, Hardik" <hardik.shah@xxxxxx> wrote:
3) Some of the lines are broken up rather badly probably to respect the
80 column maximum. Note that the 80 column maximum is a recommendation,
and that readability is more important. So IMHO it's better to have a
slightly longer line and break it up at a more logical place. However,
switching to video_ioctl2 will automatically reduce the indentation, so
this might not be that much of an issue anymore.
[Shah, Hardik] 80 column was implemented to make the checkpatch pass. Point noted and will take care of this.
The 80 column rule isn't there for nothing.
The 80 column rule is retarded. None of this code needs to fit on punch
cards, nor is it COBOL. There are legitimate reasons to have lines
longer than 80 columns. No matter how simple a program is, it is likely
to have an expression that is longer than 80 characters. Most people's
displays are wider than 80 columns these days. Vertical real estate is
at a greater premium than horizontal real estate these days with wider
aspect ratio monitors, which better approximate the human field of
vision. Why make people scan more than one line for a single expression?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
