RE: [patch twl] twl4030-core -- more cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The general policy on comments is that they should not
> be translating the C code into English.  Not only are
> such comments pointless (the C code says the same thing,
> more precisely) but they also are more likely to become
> obsolete as the code changes.  (That's a well known
> problem:  comments usually don't get updated when the
> code changes.)

Thanks for the info and point noted. :)
> 
> So in my opinion we "should" not have this comment
> just paraphrase (in English) what the code does,
> one sentence per code block.
> 

And now, I do agree.


> (And then there's the way every SIH handler seems to
> be getting its own irq_chip and handler thread.  I'm
> sure that can be done much better.)

So, is there going to be a change in the current way,
of spawning a separate thread, for power and gpio irqs?

--
Jagadeesh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux