Re: [patch] ehci-omap: (mostly) cosmetic cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 03, 2008 at 12:03:33AM -0700, David Brownell wrote:
> From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> 
> Various cleanups to the OMAP EHCI bus glue:
> 
>  - Whitespace fixes.
> 
>  - Busy-wait loops should really have timeouts, but lacking
>    that ... at least cpu_relax() in the body.
> 
>  - Debug messages should end with newlines, so they don't
>    break the next message; should not embed newlines; and
>    should otherwise be clean and correctly spelled.
> 
>  - The probe() method should have initialized the SBRN value,
>    so the driver didn't report "USB 0.0 started".
> 
>  - The MODULE_ALIAS() was missing its "platform:" prefix;
>    doing it right means the module could hotplug/coldplug.
> 
> No real functional change except for the hotplug/coldplug thing.

I actually sent this patch (besides SBRN init) way back in time but
Vikram and Anand (??) asked to hold on that patch since some patches
would come from TI for ehci and ohci.

Never saw those patches till now.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux