On Thu, Sep 18, 2008 at 3:26PM, Felipe Balbi wrote:
> Yeah, we lost some musb history when it went to mainline. I didn't test
> this patch yet cuz I've been quite busy at work, but it should make
> beagle work. Could you tell me if makes it work ?
This patch has been working for me until the latest round of twl4030 changes.
Commit fde13f8fc7de977e71304fd500fed029b41ceb19/"move twl4030-usb to
platform-device" changed subsys_initcall to module_init in
twl4030-usb.
Now, twl4030-usb is initialized after musb. This means
otg_set_transceiver is called later in boot, so the patch below gets
null back from otg_get_transceiver and oopses on *xceiv.
Unfortunately, without the patch, USB host doesn't work on the BeagleBoard.
Other than this, the new kernel seems to work pretty well for me.
- Nathan
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 9d2dcb1..f7fe91e 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -215,12 +215,14 @@ void musb_platform_set_mode(struct musb *musb, u8 musb_mode)
>
> int __init musb_platform_init(struct musb *musb)
> {
> + struct otg_transceiver *xceiv = otg_get_transceiver();
> u32 l;
>
> #if defined(CONFIG_ARCH_OMAP2430)
> omap_cfg_reg(AE5_2430_USB0HS_STP);
> #endif
>
> + memcpy(musb->xceiv, xceiv, sizeof(*xceiv));
> musb_platform_resume(musb);
>
> l = omap_readl(OTG_SYSCONFIG);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
