On Thu, Oct 02, 2008 at 04:32:31PM +0300, Peter Ujfalusi wrote:
> Yes, I know that, I just mentioned that other things are still broken in the omap-keypad driver.
> In the OMAP1 board files the resource is filled in, but in the driver you can see this:
>
> static ssize_t omap_kp_enable_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> .
> .
> if (state != kp_enable) {
> if (state)
> enable_irq(INT_KEYBOARD);
> else
> disable_irq(INT_KEYBOARD);
> kp_enable = state;
> }
> .
> .
>
> So, pretty much not a sane thing to do...
> It is easy to fix, but that was not my point.
> I'll make a patch to fix this one.
that is surely broken :-)
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
