On Wed, Oct 01, 2008 at 07:47:54PM -0700, David Brownell wrote:
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
I suppose this first one should be From:
> -static void __init twl4030_mask_clear_intrs(const struct twl4030_mod_iregs *t,
> - const u8 t_sz)
> -{
> - int i, j;
> -
> - /*
> - * N.B. - further efficiency is possible here. Eight I2C
> - * operations on BCI and GPIO modules are avoidable if I2C
> - * burst read/write transactions were implemented. Would
> - * probably save about 1ms of boot time and a small amount of
> - * power.
> - */
> - for (i = 0; i < t_sz; i++) {
> - const struct twl4030_mod_iregs tmr = t[i];
> - int cor;
> -
> - /* Are ISRs cleared by reads or writes? */
> - cor = twl4030_read_cor_bit(tmr.mod_no, tmr.sih_ctrl);
> - WARN_ON(cor < 0);
> -
> - for (j = 0; j < tmr.reg_cnt; j++) {
> -
> - /* Mask interrupts at the TWL4030 */
> - WARN_ON(twl4030_i2c_write_u8(tmr.mod_no, 0xff,
> - tmr.imrs[j]) < 0);
> -
> - /* Clear TWL4030 ISRs */
> - WARN_ON(twl4030_i2c_clear_isr(tmr.mod_no,
> - tmr.isrs[j], cor) < 0);
> - }
> - }
> -
> - return;
this return can be removed.
> +static void __init twl4030_mask_clear_intrs(const struct twl4030_mod_iregs *t,
> + const u8 t_sz)
> +{
> + int i, j;
> +
> + /*
> + * N.B. - further efficiency is possible here. Eight I2C
> + * operations on BCI and GPIO modules are avoidable if I2C
> + * burst read/write transactions were implemented. Would
> + * probably save about 1ms of boot time and a small amount of
> + * power.
> + */
> + for (i = 0; i < t_sz; i++) {
> + const struct twl4030_mod_iregs tmr = t[i];
> + int cor;
> +
> + /* Are ISRs cleared by reads or writes? */
> + cor = twl4030_read_cor_bit(tmr.mod_no, tmr.sih_ctrl);
> + WARN_ON(cor < 0);
> +
> + for (j = 0; j < tmr.reg_cnt; j++) {
> +
> + /* Mask interrupts at the TWL4030 */
> + WARN_ON(twl4030_i2c_write_u8(tmr.mod_no, 0xff,
> + tmr.imrs[j]) < 0);
> +
> + /* Clear TWL4030 ISRs */
> + WARN_ON(twl4030_i2c_clear_isr(tmr.mod_no,
> + tmr.isrs[j], cor) < 0);
> + }
> + }
> +
> + return;
also this one
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
