On Wednesday 01 October 2008, Randy Dunlap wrote: > > + These multi-function chps are found on many OMAP2 and OMAP3 > > chips Indeed ... although if e e cummings could write poetry without uppercase, surely in this modern age some literature will be forthcoming that uses no vwls? (Oh wait. That's Hebrew. ;) > > --- /dev/null > > +++ b/include/linux/i2c/twl4030-madc.h > > @@ -0,0 +1,134 @@ > > +/* > > + * include/linux/i2c/twl4030-madc.h > > + * > > + * TWL4030 MADC module driver header > > + * > > + * Copyright (C) 2008 Nokia Corporation > > + * Mikko Ylinen <mikko.k.ylinen@xxxxxxxxx> > > > > +#define TWL4030_MADC_IOC_MAGIC '`' > > Add that to Documentation/ioctl-number.txt (?) Actually one of my own review comments is that this header should become unneccessary ... and everything associated with it be dealt with when this Multi-channel ADC driver gets pushed upstream. IRQ initialization needs to be done in the core, but none of the other MADC stuff matters here. Thanks. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
