Re: [PATCH] OMAP3: Fix 34xx/35xx revision check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mans Rullgard <mans@xxxxxxxxx> writes:

> The 35xx TRM lists incorrect values for the VERSION field of the
> CONTROL_IDCODE register.  The correct values are those listed in
> the 34xx TRM.
>
> Correct message on boot verified on ES2.1 and ES3.0.
>
> Signed-off-by: Mans Rullgard <mans@xxxxxxxxx>
> ---
>  arch/arm/mach-omap2/id.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index ab7a6e9..9f72ae6 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -162,14 +162,15 @@ void __init omap34xx_check_revision(void)
>  	/*
>  	 * Detection for 34xx ES2.0 and above can be done with just
>  	 * hawkeye and rev. See TRM 1.5.2 Device Identification.
> -	 * Note that rev cannot be used directly as ES1.0 uses value 0.
> +	 * The 35xx TRM lists incorrect values for the revision number.
> +	 * Correct values are documented in the 34xx TRM.
>  	 */
>  	idcode = read_tap_reg(OMAP_TAP_IDCODE);
>  	hawkeye = (idcode >> 12) & 0xffff;
>  	rev = (idcode >> 28) & 0xff;
>
>  	if (hawkeye == 0xb7ae)
> -		system_rev = 0x34300034 | ((1 + rev) << 12);
> +		system_rev = 0x34300034 | (rev << 12);
>
>  out:
>  	switch (system_rev) {

Forget this.  A fix was already in the tree, but not merged to my
branch.

-- 
Måns Rullgård
mans@xxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux