On Tue, Sep 30, 2008 at 12:49:06PM -0700, David Brownell wrote: > From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> > > Clean up the twl4030-gpio code a bit ... mostly by shrinkage. > > Remove a bunch of macros that are just obfuscating what the > TWL4030 GPIO code is doing. Some duplicated standard macros > like BIT(); others hid trivial math (mask/shift); others were > completely unused. > > Use BIT() in several places to highlight the bitmasking and > make the code more compact. > > Remove pointless locking calls, sanity checks, and parenthesis. > And needless irq_chip. The code looks much better after you apply the patch. Great job Dave :-) -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
