Re: [PATCH 19/23] twl4030-gpio: remove legacy irq triggering calls and user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Here's an important bugfix ... strictly speaking the bug was
introduced in patch #18, but rather than redo both patches
I think it's simpler to just merge this one-liner here where
it could first have been noticed.

With this, I can confirm I've actually seen TWL triggering
GPIO interrupts ... on the appropriate edge.  At least,
when using GPIO-1, since I wasn't keen on trying to use
GPIO-0 to report removal of my SD-resident rootfs.  ;)


--- beagle.orig/drivers/gpio/twl4030-gpio.c	2008-09-30 10:28:25.000000000 -0700
+++ beagle/drivers/gpio/twl4030-gpio.c	2008-09-30 10:28:18.000000000 -0700
@@ -652,7 +652,8 @@ static int twl4030_gpio_unmask_thread(vo
 			type = desc->status & IRQ_TYPE_SENSE_MASK;
 			spin_unlock_irq(&desc->lock);
 
-			twl4030_set_gpio_edge_ctrl(irq, type);
+			twl4030_set_gpio_edge_ctrl(irq - twl4030_gpio_irq_base,
+					type);
 		}
 
 		local_irq_disable();
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux