On Mon, Sep 29, 2008 at 01:45:59PM -0700, David Brownell wrote: > On Monday 29 September 2008, Felipe Balbi wrote: > > On Mon, Sep 29, 2008 at 01:06:19PM -0700, David Brownell wrote: > > > On Monday 29 September 2008, Felipe Balbi wrote: > > > > drivers/{i2c/chips => gpio}/twl4030-gpio.c | 37 +++++++++++++++++++++++---- > > > > > > Best to avoid sending this type of patch except as backup > > > to a git pull request ... it's unusable to folk who use > > > quilt and thus don't have access to GIT extensions. > > > > > > Where "unusable" means "can't apply the patch". > > > > The good thing with the git extensions for rename detection is that we > > really see what has changed when you renamed the file and that's what > > really matters, right ? > > That's not all that matters, although I certainly liked being > able to see that specific diff and confirm "yes, that's the > stuff I had intended to change". > > A more basic point of posting patches to lists is that they be > usable for testing. And the git rename stuff prevents that. Well that's one point, yes. But only prevent for those who doesn't use git, right ? Although we can't really push everybody to drop quilt, cogito, "patch -p1", own scripts, etc. Then again, i really can't see why people still use quilt when we have stgit, which gives you quilt functionality with all git's goodies. Anyways, everybody should be able to choose a tool that fits better. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html