On Sat, Sep 27, 2008 at 02:41:40PM -0700, David Brownell wrote: > From: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> > > Move the twl4030 GPIO support from drivers/i2c/chips to drivers/gpio, > which is a more appropriate home for this code. > > The Kconfig symbol name is changed to match the GPIO_* convention for > such symbols, so config files must change in the obvious ways (Kconfig > will prompt you). There's now some helptext. > > It can now be compiled as a module, should anyone really want to > do that; that'll be mostly useful for test builds. Sanity check the > IRQ range we're given. > > Initialization order needed a bit of work too: core add_children() > called only after IRQs get set up, gpio uses subsys_initcall. This > depends on a patch making i2c driver model init use postcore_initcall. > > Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> > --- > NOTE: requires an I2C patch: > > http://marc.info/?l=i2c&m=122227316012577&w=2 > > I CC'd Jean since that doesn't seem to be in his queue yet, and > that's pretty essential to moving such TWL stuff out of the > i2c/chips directory into more appropriate locations. This patch breaks hsmmc.c: arch/arm/mach-omap2/built-in.o: In function `hsmmc_card_detect': /home/underline/workspace/linux-omap-2.6/arch/arm/mach-omap2/hsmmc.c:51: undefined reference to `twl4030_get_gpio_datain' arch/arm/mach-omap2/built-in.o: In function `hsmmc_cleanup': /home/underline/workspace/linux-omap-2.6/arch/arm/mach-omap2/hsmmc.c:93: undefined reference to `twl4030_free_gpio' arch/arm/mach-omap2/built-in.o: In function `hsmmc_late_init': /home/underline/workspace/linux-omap-2.6/arch/arm/mach-omap2/hsmmc.c:64: undefined reference to `twl4030_request_gpio' /home/underline/workspace/linux-omap-2.6/arch/arm/mach-omap2/hsmmc.c:68: undefined reference to `twl4030_set_gpio_edge_ctrl' /home/underline/workspace/linux-omap-2.6/arch/arm/mach-omap2/hsmmc.c:78: undefined reference to `twl4030_set_gpio_debounce' -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
