From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> One twl4030_request_gpio() should not tamper with the pullup enabling/disabling of the rest of the GPIOs. So removing the default pullup values written to REG_GPIOPUPDCTR1. Signed-off-by: Girish S G <girishsg@xxxxxx> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> --- drivers/i2c/chips/twl4030-gpio.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/chips/twl4030-gpio.c b/drivers/i2c/chips/twl4030-gpio.c index 4d89abc..b51bed0 100644 --- a/drivers/i2c/chips/twl4030-gpio.c +++ b/drivers/i2c/chips/twl4030-gpio.c @@ -301,7 +301,6 @@ int twl4030_request_gpio(int gpio) if (gpio_usage_count & (0x1 << gpio)) ret = -EBUSY; else { - u8 clear_pull[6] = { 0, 0, 0, 0, 0, 0 }; /* First time usage? - switch on GPIO module */ if (!gpio_usage_count) { ret = @@ -311,10 +310,6 @@ int twl4030_request_gpio(int gpio) } if (!ret) gpio_usage_count |= (0x1 << gpio); - - ret = - twl4030_i2c_write(TWL4030_MODULE_GPIO, clear_pull, - REG_GPIOPUPDCTR1, 5); } up(&gpio_sem); return ret; -- 1.6.0.2.307.gc427 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html