> On Thursday 25 September 2008, Pakaravoor, Jagadeesh wrote: >> From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> >> >> One twl4030_request_gpio() should not tamper with the pullup >> enabling/disabling of the rest of the GPIOs. So removing the default >> pullup values written to REG_GPIOPUPDCTR1. >> >> Signed-off-by: Girish S G <girishsg@xxxxxx> >> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> > > Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> > > Now I can remove this from my own GPIO cleanups. ;) that all MMC/SD signals have > an external pullup. (Except maybe DAT4..DAT7 for MMC+.) > > Need for such a pullup should be in board-specific init > data, for boards which need it. I second that, pullup/dn can go in board-specific file. Girish -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
