Re: [PATCH 5/10] HDQ driver: Convert few declarations to static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 25, 2008 at 12:25:11PM +0530, ext Gadiyar, Anand wrote:
> From: Madhusudhan Chikkature <madhu.cr@xxxxxx>
> 
> Convert declaration to static.
> 
> Signed-off-by: Madhusudhan Chikkature <madhu.cr@xxxxxx>
Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> ---
>  drivers/w1/masters/omap_hdq.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> Index: linux-omap-2.6/drivers/w1/masters/omap_hdq.c
> ===================================================================
> --- linux-omap-2.6.orig/drivers/w1/masters/omap_hdq.c	2008-09-24 10:10:07.000000000 +0530
> +++ linux-omap-2.6/drivers/w1/masters/omap_hdq.c	2008-09-24 10:19:28.000000000 +0530
> @@ -49,8 +49,8 @@
>  
>  #define OMAP_HDQ_MAX_USER			4
>  
> -DECLARE_WAIT_QUEUE_HEAD(hdq_wait_queue);
> -int W1_ID;
> +static DECLARE_WAIT_QUEUE_HEAD(hdq_wait_queue);
> +static int w1_id;
>  
>  struct hdq_data {
>  	struct device		*dev;
> @@ -249,8 +249,8 @@ static void omap_w1_search_bus(void *_hd
>  {
>  	u64 module_id, rn_le, cs, id;
>  
> -	if (W1_ID)
> -		module_id = W1_ID;
> +	if (w1_id)
> +		module_id = w1_id;
>  	else
>  		module_id = 0x1;
>  
> @@ -715,7 +715,7 @@ omap_hdq_exit(void)
>  module_init(omap_hdq_init);
>  module_exit(omap_hdq_exit);
>  
> -module_param(W1_ID, int, S_IRUSR);
> +module_param(w1_id, int, S_IRUSR);
>  
>  MODULE_AUTHOR("Texas Instruments");
>  MODULE_DESCRIPTION("HDQ driver Library");
-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux