On Wed, Sep 24, 2008 at 04:49:08PM +0530, ext Madhusudhan Chikkature wrote:
> Hi Tony,
>
> I am posting a series of nine patches for the HDQ driver. The patch series
> provides cleanup of the driver pointed out by Filipe's diff file, use ioremap
> for HDQ base, replace usage of semaphore with mutex, fixes some commenting
> style and indentation.
one more (and hopefully last) comment, hdq_reg_out should return void:
static inline void hdq_reg_out(struct hdq_data *hdq_data, u32 offset, u8 val)
{
__raw_writeb(val, hdq_data->hdq_base + offset);
}
If you fix the comments I gave now, I think the patches should be
applied unless someone else has any comments to them. After that, you
could also prepare a patch sending this particular driver to
Evgeniy Polyakov <johnpol@xxxxxxxxxxx> Cc:ing
linux-kernel@xxxxxxxxxxxxxxx and linux-omap@xxxxxxxxxxxxxxx
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
