Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Op 23 sep 2008, om 13:00 heeft Tony Lindgren het volgende geschreven:

* David Brownell <david-b@xxxxxxxxxxx> [080920 20:23]:
On Friday 19 September 2008, arun c wrote:
without this the below error messages were coming continuously

TWL4030 module irq 369 is disabled but can't be masked!

I can see how it would fix that.  :)

But this is also a good illustration of why this keypad device
should be initialized differently ... this particular data is
not board-specific, and the root cause of the problem was that
the device wasn't set up as part of twl4030 setup.

The clean fix requires twl4030 to be a "new style" driver.
Fix not yet available. :(

Pushing until we have a better fix.

But twl4030 now is a "new style" driver, so we have a start :)

regards,

Koen




Tony


- Dave


Signed-off-by: Arun C <arunedarath@xxxxxxxxxxxxxxxxxxxx>
---
arch/arm/mach-omap2/board-omap3evm.c |    2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c
b/arch/arm/mach-omap2/board-omap3evm.c
index 92f70ce..f9fd06b 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -22,6 +22,7 @@
#include <linux/input.h>
#include <linux/spi/spi.h>
#include <linux/spi/ads7846.h>
+#include <linux/i2c/twl4030.h>

#include <mach/hardware.h>
#include <asm/mach-types.h>
@@ -176,6 +177,7 @@ static struct omap_kp_platform_data omap3evm_kp_data = {
	.keymap 	= omap3evm_keymap,
	.keymapsize	= ARRAY_SIZE(omap3evm_keymap),
	.rep		= 1,
+	.irq		= TWL4030_MODIRQ_KEYPAD,
};

static struct platform_device omap3evm_kp_device = {
--
--
To unsubscribe from this list: send the line "unsubscribe linux- omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux- omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Attachment: PGP.sig
Description: This is a digitally signed message part


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux