On Fri, Sep 19, 2008 at 01:23:41AM +0300, Felipe Balbi wrote: > + > return 0; > } > - > -#else > -#define omap_wdt_suspend NULL > -#define omap_wdt_resume NULL > #endif > > static struct platform_driver omap_wdt_driver = { > .probe = omap_wdt_probe, > .remove = omap_wdt_remove, > +#ifdef CONFIG_PM > .shutdown = omap_wdt_shutdown, > .suspend = omap_wdt_suspend, > +#endif I prefer to see the function names defined to NULL rather than adding extra ifdefs into drivers. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html