[PATCH v2 07/11] OMAP2/3 clock: use prcm_mod field in omap2_clk_wait_ready()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Use the newly-added clk.prcm_mod field in omap2_clk_wait_ready(),
removing some internal register arithmetic.

Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
---
 arch/arm/mach-omap2/clock.c |   17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index ebf2d7e..6433679 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -302,10 +302,13 @@ int omap2_wait_clock_ready(void __iomem *reg, u32 mask, const char *name)
 static void omap2_clk_wait_ready(struct clk *clk)
 {
 	u32 other_bit, idlest_bit;
-	unsigned long reg, other_reg, idlest_reg, prcm_mod, prcm_regid;
+	unsigned long reg, other_reg, idlest_reg, prcm_regid;
+
+	/* Only CM-controlled clocks affect module IDLEST */
+	if (clk->prcm_mod & ~PRCM_MOD_ADDR_MASK)
+		return;
 
 	reg = (unsigned long)clk->enable_reg;
-	prcm_mod = reg & ~0xff;
 	prcm_regid = reg & 0xff;
 
 	other_reg = reg & ~PRCM_REGTYPE_MASK;
@@ -321,9 +324,7 @@ static void omap2_clk_wait_ready(struct clk *clk)
 	idlest_bit = other_bit;
 
 	/* 24xx: DSS and CAM have no idlest bits for their target agents */
-	if (cpu_is_omap24xx() &&
-	    (prcm_mod == OMAP2420_CM_REGADDR(CORE_MOD, 0) ||
-	     prcm_mod == OMAP2430_CM_REGADDR(CORE_MOD, 0)) &&
+	if (cpu_is_omap24xx() && clk->prcm_mod == CORE_MOD &&
 	    (reg & 0x0f) == 0) { /* CM_{F,I}CLKEN1 */
 
 		if (clk->enable_bit == OMAP24XX_EN_DSS2_SHIFT ||
@@ -337,7 +338,7 @@ static void omap2_clk_wait_ready(struct clk *clk)
 	if (cpu_is_omap34xx()) {
 
 		/* SSI */
-		if (prcm_mod == OMAP34XX_CM_REGADDR(CORE_MOD, 0) &&
+		if (clk->prcm_mod == CORE_MOD &&
 		    (reg & 0x0f) == 0 &&
 		    clk->enable_bit == OMAP3430_EN_SSI_SHIFT) {
 
@@ -348,7 +349,7 @@ static void omap2_clk_wait_ready(struct clk *clk)
 		}
 
 		/* DSS */
-		if (prcm_mod == OMAP34XX_CM_REGADDR(OMAP3430_DSS_MOD, 0)) {
+		if (clk->prcm_mod == OMAP3430_DSS_MOD) {
 
 			/* 3430ES1 DSS has no target idlest bits */
 			if (system_rev == OMAP3430_REV_ES1_0)
@@ -366,7 +367,7 @@ static void omap2_clk_wait_ready(struct clk *clk)
 
 		/* USBHOST */
 		if (system_rev > OMAP3430_REV_ES1_0 &&
-		    prcm_mod == OMAP34XX_CM_REGADDR(OMAP3430ES2_USBHOST_MOD, 0)) {
+		    clk->prcm_mod == OMAP3430ES2_USBHOST_MOD) {
 
 			/*
 			 * The 120MHz clock apparently has nothing to do with


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux