Re: [PATCH 1/1] Use pmd_table() MACRO for unmap_area_sections()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Russell,

From: "ext Russell King - ARM Linux" <linux@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/1] Use pmd_table() MACRO for unmap_area_sections()
Date: Fri, 5 Sep 2008 23:45:30 +0100

> On Fri, Sep 05, 2008 at 10:21:33AM -0700, Tony Lindgren wrote:
> > * Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> [080902 22:37]:
> > > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx>
> > 
> > This should be sent to linux-arm-kernel list.
> 
> Except, pmd_table() is an omap thing at the moment, so isn't relevant
> there.

Right.
Would it be possible to have "pmd_table()" definition "in pgtable.h"?

>From 0374c2c3e873a43e26cb439b891b9e319b90f83c Mon Sep 17 00:00:00 2001
From: ext Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx>
Date: Wed, 3 Sep 2008 08:36:28 +0300
Subject: [PATCH 1/1] Add pmd_table() MACRO

Use pmd_table() MACRO for unmap_area_sections()

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx>
---
 arch/arm/include/asm/pgtable.h |    1 +
 arch/arm/mm/ioremap.c          |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index 8e21ef1..acfac1a 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -292,6 +292,7 @@ static inline pte_t pte_mkspecial(pte_t pte) { return pte; }
 #define pmd_none(pmd)		(!pmd_val(pmd))
 #define pmd_present(pmd)	(pmd_val(pmd))
 #define pmd_bad(pmd)		(pmd_val(pmd) & 2)
+#define pmd_table(pmd)		((pmd_val(pmd) & PMD_TYPE_MASK) == PMD_TYPE_TABLE)
 
 #define copy_pmd(pmdpd,pmdps)		\
 	do {				\
diff --git a/arch/arm/mm/ioremap.c b/arch/arm/mm/ioremap.c
index b81dbf9..7ab4301 100644
--- a/arch/arm/mm/ioremap.c
+++ b/arch/arm/mm/ioremap.c
@@ -161,7 +161,7 @@ static void unmap_area_sections(unsigned long virt, unsigned long size)
 			/*
 			 * Free the page table, if there was one.
 			 */
-			if ((pmd_val(pmd) & PMD_TYPE_MASK) == PMD_TYPE_TABLE)
+			if (pmd_table(pmd))
 				pte_free_kernel(&init_mm, pmd_page_vaddr(pmd));
 		}
 
-- 
1.5.5.1.357.g1af8b

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux