On Fri, Sep 05, 2008 at 01:34:03PM -0600, Paul Walmsley wrote: > We must not attempt to wait for the CAM module to become ready after > clock enable, since it has no target IDLEST bit. Grrr. These things seem to be collecting here, and in need of a more generic and elegant solution. (Please always do that rather than extending an already existing hack.) In mainline, I see a bunch of exclusions in omap2_clk_wait_ready() for OMAP24xx and OMAP34xx. Your struct clk has a 'flags' field. Currently, bits 13 to 20 are free. Enough room to fit into it two extra bits - a "don't wait for OMAP24xx" and "don't wait for OMAP34xx" bits. They can then be used thusly: if (cpu_is_omap24xx() && clk->flags & CLK_NOWAIT_24XX) return; if (cpu_is_omap34xx() && clk->flags & CLK_NOWAIT_34XX) return; rather than throwing individual exceptions into clock.c. Such a solution is far more elegant, easier to review, and likely to be far smaller in the long run - both in terms of lines of change and code size. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
