Re: cam_mclk clock not responding properly in OMAP3430

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sergio,

On Thu, 4 Sep 2008, Aguirre Rodriguez, Sergio Alberto wrote:

> I'm working on camera implementation, and I want to debug why the cam_mclk clock is returning me a "count exceeded" message, although seems to be properly taken. (i.e. MT9P012 + ISP sensor works fine)
> 
> I'm having this message when trying to acquire it:
> 
> Clock cam_mclk didn't enable in 100000 tries
> 
> Any clue why is that?

Yes, I think so.  Does this patch fix the problem for you?


- Paul


[PATCH] OMAP3 clock: camera module has no target IDLEST bit

From: Paul Walmsley <paul@xxxxxxxxx>

We must not attempt to wait for the CAM module to become ready after
clock enable, since it has no target IDLEST bit.

Thanks to Sergio Alberto Aguirre Rodriguez <saaguirre@xxxxxx> for
reporting this.

Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
Cc: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@xxxxxx>
---
 arch/arm/mach-omap2/clock.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index be5c616..189b8a6 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -256,6 +256,10 @@ static void omap2_clk_wait_ready(struct clk *clk)
 	/* REVISIT: What are the appropriate exclusions for 34XX? */
 	if (cpu_is_omap34xx()) {
 
+		/* CAM */
+		if (prcm_mod == OMAP34XX_CM_REGADDR(OMAP3430_CAM_MOD, 0))
+			return;
+
 		/* SSI */
 		if (prcm_mod == OMAP34XX_CM_REGADDR(CORE_MOD, 0) &&
 		    (reg & 0x0f) == 0 &&
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux