Re: [PATCH 0/2] twl4030-usb patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 02, 2008 at 03:31:50PM +0300, Felipe Balbi wrote:
> The following patches convert twl4030-usb to a platform_device
> in order to set the usb mode via platform_data and get
> rid of the Kconfig entry for that.
> 
> Later, we add a sysfs entry for reporting the vbus events
> coming from triton, this let's us tell the userspace we
> have a usb connection (vbus is on) and trigger an application
> or something else.

Just one comment here. I'll apply these to the big series of drivers
going to mainline.

TWL4030 driver won't be accepted the way it is now. Starting from the
fact that twl4030-core is an old style i2c driver and Jean Delvare
already stated his plans to drop support for old style i2c drivers.

twl4030-usb is already moved to platform_driver, twl4030_gpio should be
moved to gpiolib also before sending to mainline.

Comments are really welcome.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux