On Tue, Sep 02, 2008 at 02:13:27PM +0800, stanley.miao wrote:
> @@ -76,6 +81,11 @@ static int sdp2430_panel_enable(struct lcd_panel
> *panel)
> {
> u8 ded_val, ded_reg;
> u8 grp_val, grp_reg;
> +
> + if(is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
missing space "if ()".
> @@ -104,6 +114,11 @@ static void sdp2430_panel_disable(struct lcd_panel
> *panel)
> {
> omap_set_gpio_dataout(enable_gpio, 0);
> omap_set_gpio_dataout(backlight_gpio, 0);
nothing to do with your patch, but these should be converted to
gpiolib.
> + if(is_sil_rev_greater_than(OMAP3430_REV_ES1_0)) {
missing space again. Please, run scripts/checkpatch.pl --strict patch.diff
before sending your patches so we avoid obvious style mistakes.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
