-----Original Message----- From: Russell King - ARM Linux [mailto:linux@xxxxxxxxxxxxxxxx] Sent: Tuesday, September 02, 2008 1:41 AM To: Premi, Sanjeev Cc: linux-omap@xxxxxxxxxxxxxxx Subject: Re: [PATCH 2/3] Runtime check for OMAP35x On Tue, Sep 02, 2008 at 01:27:46AM +0530, Sanjeev Premi wrote: > Based on earlier review comments, added runtime check of the OMAP35x > via omap2_set_globasl_3503() etc. > --- > arch/arm/plat-omap/common.c | 76 ++++++++++++++++++++++++++++++++++ > include/asm-arm/arch-omap/common.h | 4 ++ > include/asm-arm/arch-omap/cpu.h | 79 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 159 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c > index 3a5f05e..f8b04cc 100644 > --- a/arch/arm/plat-omap/common.c > +++ b/arch/arm/plat-omap/common.c > @@ -334,3 +334,79 @@ void __init omap2_set_globals_343x(void) } > #endif > > +#if defined(CONFIG_ARCH_OMAP3503) > + > +static struct omap_globals omap3503_globals = { > + .class = OMAP35XX_CLASS, > + .tap = (__force void __iomem *)OMAP2_IO_ADDRESS(0x4830A000), See my comments elsewhere about why this is Really Bad. Any casts outside of a few header files using __force are basically a bug. In this case, you're being forced to use them because OMAP2_IO_ADDRESS doesn't return the proper pointer values. (I produced a patch for comment on this list last week over this issue.) [sp] I was trying to be consistent/similar with current code in the file. Will make appropriate changes as you suggest. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
