Hello Daniel, On Wed, 27 Aug 2008, Daniel Stone wrote: > The GFX/SGX functional and interface clocks have different masks, for > some unknown reason, so split EN_SGX_SHIFT into one each for fclk and > iclk. thanks for the fix, this looks mostly good - one comment: > diff --git a/arch/arm/mach-omap2/cm-regbits-34xx.h b/arch/arm/mach-omap2/cm-regbits-34xx.h > index ffb695b..06a78a7 100644 > --- a/arch/arm/mach-omap2/cm-regbits-34xx.h > +++ b/arch/arm/mach-omap2/cm-regbits-34xx.h > @@ -339,9 +339,11 @@ > #define OMAP3430ES1_CLKACTIVITY_GFX_SHIFT 0 > #define OMAP3430ES1_CLKACTIVITY_GFX_MASK (1 << 0) > > -/* CM_FCLKEN_SGX */ > -#define OMAP3430ES2_EN_SGX_SHIFT 1 > -#define OMAP3430ES2_EN_SGX_MASK (1 << 1) > +/* CM_FCLKEN_SGX/CM_ICLKEN_SGX */ > +#define OMAP3430ES2_EN_SGX_FSHIFT 1 > +#define OMAP3430ES2_EN_SGX_FMASK (1 << 1) > +#define OMAP3430ES2_EN_SGX_ISHIFT 0 > +#define OMAP3430ES2_EN_SGX_IMASK (1 << 0) To keep these consistent with prior practice in prm-regbits-34xx.h for name collisions, could you change the above to look something like: /* CM_FCLKEN_SGX */ #define OMAP3430ES2_CM_FCLKEN_SGX_EN_SGX_SHIFT 1 #define OMAP3430ES2_CM_FCLKEN_SGX_EN_SGX_MASK (1 << 1) /* CM_ICLKEN_SGX */ #define OMAP3430ES2_CM_ICLKEN_SGX_EN_SGX_SHIFT 0 #define OMAP3430ES2_CM_ICLKEN_SGX_EN_SGX_MASK (1 << 0) Ugly, but unambiguous. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
