Re: [PATCH] OMAP:MUSB: Corrects urb unlink function path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 22, 2008 at 12:00:56PM +0530, ext ajay.gupta@xxxxxx wrote:
> From: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
> 
> Fixes kernel panic while ISO IN transfer is aborted.Replaced
> usb_hcd_unlink_urb_from_ep() from musb_giveback() to __musb_giveback()
> to make sure urb is unlinked before giveback when __musb_giveback() is
> called from musb_urb_dequeue().

looks right as well

note: please break your patch header after 72 caracters

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
> ---
>  drivers/usb/musb/musb_host.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 93b0678..a889ac4 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -292,6 +292,7 @@ __acquires(musb->lock)
>  			);
>  
>  	spin_unlock(&musb->lock);
> +	usb_hcd_unlink_urb_from_ep(musb_to_hcd(musb), urb);
>  	usb_hcd_giveback_urb(musb_to_hcd(musb), urb, status);
>  	spin_lock(&musb->lock);
>  }
> @@ -353,8 +354,6 @@ musb_giveback(struct musb_qh *qh, struct urb *urb, int status)
>  		break;
>  	}
>  
> -	usb_hcd_unlink_urb_from_ep(musb_to_hcd(musb), urb);
> -
>  	qh->is_ready = 0;
>  	__musb_giveback(musb, urb, status);
>  	qh->is_ready = ready;
> -- 
> 1.5.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux