On Thu, Aug 21, 2008 at 07:28:42PM +0530, ext Swaminathan S wrote:
>
> Signed-off-by: Swaminathan S <swami.iyer@xxxxxx>
>
> This patch implements a tasklet to poll for TX Endpoint FIFO
> empty status before completing a transfer. This is required
> in the context of DaVinci CPPI DMA Tx transfers. CPPI
> DMA engine generates completion interrupt before the data
> actually moves out of TX FIFO and the driver needs to save the
> Data toggle after ensuring that the FIFO is empty.
same comments from before.
> diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
> index d443a61..9dd24c3 100644
> --- a/drivers/usb/musb/davinci.c
> +++ b/drivers/usb/musb/davinci.c
> @@ -421,6 +421,12 @@ int __init musb_platform_init(struct musb *musb)
> musb_readb(tibase, DAVINCI_USB_CTRL_REG));
>
> musb->isr = davinci_interrupt;
> +#ifdef CONFIG_USB_MUSB_HDRC_HCD
use if (is_host_capable()) instead.
> + if (hw_ep->fifo_flush_check) {
> + csr = musb_readw(hw_ep->regs, MUSB_TXCSR);
> + if (((csr & MUSB_TXCSR_FIFONOTEMPTY) ||
> + (csr & MUSB_TXCSR_TXPKTRDY)))
> + sch_tsklt = 1;
> + else {
put {} on both branches.
> +
this new line is unnecessary
this was just a primary overview. I wanna test more this patch since it
changes a bit musb_ep_program() which would affect all archs using musb.
I'll leave my n810 testing during this weekend and get back to you later
on.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
