Re: [RFC][PATCH 1/1] serial: OMAP driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hi,
>
> 2008/7/31 Girish. S. G. <girishsg@xxxxxx>:
>> Serial driver for OMAP Uart controllers
>>
>> Signed-off-by: Girish S G <girishsg@xxxxxx>
>> ---

>> +       /* Reset the UART */
>> +       serial_out(up, UART_OMAP_MDR1, 0x07);
>> +       serial_out(up, UART_OMAP_SCR, 0x08);
>> +       serial_out(up, UART_OMAP_MDR1, 0x00);
>> +       serial_out(up, UART_OMAP_SYSC, (0x02 << 3) | (1 << 2) | (1 << 0));
>
> Should this also work on older OMAPs? (The Kconfig allows building on omap1)
> OMAP15xx didn't have the SYSC register, instead MDR1 resets the
> module. I haven't checked the other registers used in this driver.

That's good point. I don't have OMAP15xx and it would definitely help full if
somebody in community validate it. I will send the patch with your comment
included.

Regards,
Girish

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux