On Tue, Aug 19, 2008 at 07:50:26PM +0530, ext Pakaravoor, Jagadeesh wrote: > From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> > > TWL4030-RTC: Remove obsolete comment. > > Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx> > Index: my-local-git-dir/drivers/rtc/rtc-twl4030.c > =================================================================== > --- my-local-git-dir.orig/drivers/rtc/rtc-twl4030.c 2008-08-19 19:20:24.000000000 +0530 > +++ my-local-git-dir/drivers/rtc/rtc-twl4030.c 2008-08-19 19:28:43.037746119 +0530 > @@ -446,12 +446,6 @@ static irqreturn_t twl4030_rtc_interrupt > REG_RTC_STATUS_REG); > if (res) > goto out; > - /* > - * Workaround for strange behaviour with T2. Need to write into ISR > - * register one more time to clear the interrupt. Otherwise, the same > - * RTC event generates 2 interrupts in a row. > - * (no errata document available) > - */ > res = twl4030_i2c_write_u8(TWL4030_MODULE_INT, > PWR_RTC_INT_CLR, REG_PWR_ISR1); > if (res) Why is this obsolete? Seems quite a good comment to me. Removing it might turn into someone removing that line and make t2's rtc misbehave. Maybe you wanna remove only the "no errata" line if there is any errata available but the comment itself is quite valuable. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
