Re: [PATCH] [MTD] OneNAND OMAP3: add delay for GPIO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Adrian Hunter <ext-adrian.hunter@xxxxxxxxx> [080814 14:21]:
> On OMAP3, the driver was occasionally not seeing the GPIO
> interrupt.  Adding a small delay of one register read
> eliminates the problem.

Pushing to linux-omap tree.

Tony

> Signed-off-by: Adrian Hunter <ext-adrian.hunter@xxxxxxxxx>
> ---
> drivers/mtd/onenand/omap2.c |    9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 2bd8746..bf6bba5 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -141,8 +141,13 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state)
>
> 		/* Turn interrupts on */
> 		syscfg = read_reg(c, ONENAND_REG_SYS_CFG1);
> -		syscfg |= ONENAND_SYS_CFG1_IOBE;
> -		write_reg(c, syscfg, ONENAND_REG_SYS_CFG1);
> +		if (!(syscfg & ONENAND_SYS_CFG1_IOBE)) {
> +			syscfg |= ONENAND_SYS_CFG1_IOBE;
> +			write_reg(c, syscfg, ONENAND_REG_SYS_CFG1);
> +			if (cpu_is_omap34xx())
> +				/* Add a delay to let GPIO settle */
> +				syscfg = read_reg(c, ONENAND_REG_SYS_CFG1);
> +		}
>
> 		INIT_COMPLETION(c->irq_done);
> 		if (c->gpio_irq) {
> -- 
> 1.5.4.3
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux