----- Original Message -----
From: "David Brownell" <david-b@xxxxxxxxxxx>
To: <tony@xxxxxxxxxxx>; <madhu.cr@xxxxxx>
Cc: <linux-omap@xxxxxxxxxxxxxxx>
Sent: Wednesday, August 13, 2008 2:24 PM
Subject: Re: [PATCH]Add 3430 SDP board level support for HSMMC2
>> arch/arm/mach-omap2/board-3430sdp.c | 4
>> arch/arm/mach-omap2/hsmmc.c | 185 ++++++++++++++++++++++++++++++++
>
> hsmmc.c is used by Beagle too, yet ...
>
>
>> void __init hsmmc_init(void)
>> {
>> omap_set_mmc_info(1, &hsmmc_data);
>> + omap_set_mmc_info(2, &hsmmc2_data);
>> }
>
> ... MMC2 is rarely enabled on Beagle, so this is incorrect.
There is an another level of abstraction at the board level files like board-3430sdp.c,board-omap3beagle.c, board-omap3evm.c..
I see that the beagle board file does not enable hsmmc2. So the platform device for the second controller is not registered anyway.
>
>
> A better way to do this would be to let the boards say exactly
> what the hardware configuration is, rather than requiring all
> OMAP3 boards to be set up exactly like the SDP...
I think the initial version was written specific to SDP. Later on it was changed to hsmmc.c and the platforms
which required simillar setup as SDP started using it. Now, if support for a new board is required which is unlike SDP a
new file can still be added for that perticular board, right?
Regards,
Madhu
>
> - Dave
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
