>
> >
> > Serial and gpio clock disabling and gpio_prepare/resume can
> be removed
> > from omap3_pm_idle because they are already done in omap_sram_idle.
> > And if omap_serial_can_sleep is removed from
> omap3_can_sleep it should
> > be added to omap3_pm_idle.
> > Omap3_pm_idle can be also put behind #ifndef CONFIG_CPU_IDLE:
> >
> > +#ifndef CONFIG_CPU_IDLE
> > static void omap3_pm_idle(void)
> > {
> > local_irq_disable();
> > @@ -454,33 +455,16 @@ static void omap3_pm_idle(void)
> > if (omap_irq_pending())
> > goto out;
> >
> > - omap2_gpio_prepare_for_retention();
> > -
> > - if (clocks_off_while_idle) {
> > - omap_serial_enable_clocks(0, 0);
> > - omap_serial_enable_clocks(0, 1);
> > - omap_serial_enable_clocks(0, 2);
> > - /* XXX This is for gpio fclk hack. Will be
> removed as
> > - * gpio driver * handles fcks correctly */
> > - per_gpio_clk_disable();
> > - }
> > + if (!omap_serial_can_sleep())
> > + goto out;
> >
> > omap_sram_idle();
> >
> > - if (clocks_off_while_idle) {
> > - omap_serial_enable_clocks(1, 0);
> > - omap_serial_enable_clocks(1, 1);
> > - omap_serial_enable_clocks(1, 2);
> > - /* XXX This is for gpio fclk hack. Will be
> removed as
> > - * gpio driver * handles fcks correctly */
> > - per_gpio_clk_enable();
> > - }
> > -
> > - omap2_gpio_resume_after_retention();
> > out:
> > local_fiq_enable();
> > local_irq_enable();
> > }
> > +#endif /* CONFIG_CPU_IDLE */
>
> These are also done as part of the last patch in the series.
>
Ok.. so I misunderstood your comment initially, I confused omap3_pm_idle with the
omap3_enter_idle and thought this was already done.
Yes, these can be now removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
