Re: [PATCH RFC] MUSB: Fix index register corruption seen with g_ether and Windows host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 05 August 2008, Gadiyar, Anand wrote:
> If Indexed Mode register accesses are enabled, the ep0_rxstate() function calls
> musb_g_ep0_giveback() before writing to the CSR register. When control returns
> to this ep0_rxstate, the index register contents are over-written. This causes
> the CSR register write to fail.
> 
> Fixed by writing the correct value into the index register before
> writing to the CSR.
>	...
> Dave, you wrote the original commit (5dd8c56c) on linux-omap that moved the
> register write after the call to the giveback function [1]. Could you take
> a look at this patch please?

This looks fair.  All it does is make sure that the index
register points where it's expected to point; what could
that break?


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux