On Tue, Aug 5, 2008 at 11:48 PM, Gadiyar, Anand <gadiyar@xxxxxx> wrote: > From: Anand Gadiyar <gadiyar@xxxxxx> > > If Indexed Mode register accesses are enabled, the ep0_rxstate() function calls > musb_g_ep0_giveback() before writing to the CSR register. When control returns > to this ep0_rxstate, the index register contents are over-written. This causes > the CSR register write to fail. > > Fixed by writing the correct value into the index register before > writing to the CSR. > > This was observed only in ep0_rxstate() with g_ether loaded and the device > connected to a MS Windows host PC. Anticipatively fixed ep0_txstate() as well. > Actually, I'm still struggling in a bug similar with this one on Blackfin. We ran following testcase 100 times, 10-20 times tastcases failed. --- $ ./testusb -D /proc/bus/usb/005/012 -t14 -c 15000 -s 256 -v 1 unknown speed /proc/bus/usb/005/012 /proc/bus/usb/005/012 test 14 --> 75 (Value too large for defined data type) --- I reported this bug to our hardware designer and the omap list. Felipe said he did met this issue. >From the capture data of USB analyzer, the peripheral musb sent out garbage data in the IN-STATUS stage. In that stage, the DATA length should be zero. But the peripheral sent out 1 byte or 2 bytes sometimes. Thanks -Bryan > Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx> > Cc: David Brownell <david-b@xxxxxxxxxxx> > --- > This patch will probably turn up with tabs replaced by spaces - my mailer is > broken. Will fix that or find another one. Till then, this is RFC. The patch > was based on the linux-omap git tree but that tab-to-space issue should cause > the patch to not apply. > > Dave, you wrote the original commit (5dd8c56c) on linux-omap that moved the > register write after the call to the giveback function [1]. Could you take > a look at this patch please? > > [1] <http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=5dd8c56c0bb1aaadbf6540de8350161c7a9f7034> > > drivers/usb/musb/musb_gadget_ep0.c | 2 ++ > 1 files changed, 2 insertions(+) > > Index: 04aug_ccase/drivers/usb/musb/musb_gadget_ep0.c > =================================================================== > --- 04aug_ccase.orig/drivers/usb/musb/musb_gadget_ep0.c > +++ 04aug_ccase/drivers/usb/musb/musb_gadget_ep0.c > @@ -476,6 +476,7 @@ static void ep0_rxstate(struct musb *mus > return; > musb->ackpend = 0; > } > + musb_ep_select(musb->mregs, 0); > musb_writew(regs, MUSB_CSR0, tmp); > } > > @@ -528,6 +529,7 @@ static void ep0_txstate(struct musb *mus > } > > /* send it out, triggering a "txpktrdy cleared" irq */ > + musb_ep_select(musb->mregs, 0); > musb_writew(regs, MUSB_CSR0, csr); > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
